search

nguyenquyhy / DiscordBridge

A Sponge plugin to integrate Minecraft server with a Discord channel
MIT License
31 stars 18 forks source link

2 Small things #20

Closed Vankka closed 7 years ago

Vankka commented 7 years ago
Vankka commented 7 years ago

Also a little config change of one line

"botToken": "", "prefixBlacklist": "", "minecraftBroadcastTemplate": "",

nguyenquyhy commented 7 years ago

Can you make this "Messages from bot user won't send in-game" configurable?

The reason I used the special char instead of the bot ID is that I still want bot's messages to be able to forward to Minecraft except those from the plugin itself. For example, I have PixelBot to route messages between Pixelmon servers and Discord. At the same time, there is a separate Python engine that allows PixelBot to answer questions. So I want people from Minecraft to be able to ask a question, the question routes to Discord by Discord Bridge, the Python engine answers the question in Discord (also using PixelBot) and the answer is routed back to Minecraft by Discord Bridge.

I think a good way would be adding something like "useSpecialChar": false. If it is set to false (default), just use bot ID and ignore this content.contains(TextUtil.SPECIAL_CHAR, if it is set to true, do the reversed.

What do you think about that?

nguyenquyhy commented 7 years ago

Also, do you think prefixBlacklist should be a list? 😄 Is that overkill?

Vankka commented 7 years ago

hmm propably can manage to do that but i'm not sure i know how to do the table thing as i just wanted to make a separate discord.js thing to work with the sane bit as the plugin so i can make a command for !players and have it not spam in game and someone wanted me to make a pr :D

Vankka commented 7 years ago

oh crap... the files from my pc transfered

Vankka commented 7 years ago

i don't know how to pr lol

nguyenquyhy commented 7 years ago

It is quite a lot of commit here, so I will squash it and merge. You might have to do a force pull and push from this repo though. I will add change the blacklist into a list and clean unnecessary files :).

Many thanks for the new features! 👍

Vankka commented 7 years ago

okay but i just added the config option for the bot message cancel thing xD

Vankka commented 7 years ago

nvm all the things are in

Vankka commented 7 years ago

pst you should look thru the commit as i intended this to just be my little fork so some things such as -vFork happend...

nguyenquyhy commented 7 years ago

Yep I have looked through every files 😄