Closed emmamarichal closed 1 year ago
Hello @nguyentype, have you seen this PR? It would be great if you can merge, so we can update the font :) Cheers!
Hi Emma,Can you guide me what I should do? 😁Thank you,Nguyen Type
On Wed, 24 May 2023 at 14:03 Emma wrote:
Hello @nguyentype, have you seen this PR? It would be great if you can merge, so we can update the font :) Cheers!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.> [ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/nguyentype/vinasans/pull/4#issuecomment-1560561207", "url": "https://github.com/nguyentype/vinasans/pull/4#issuecomment-1560561207", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
Sure! You can see the new version of the font in the PR, which come from a fork I created on my side: https://github.com/emmamarichal/vinasans
And if you are ok with the changes I made, you can merge this Pull Request :)
Thanks!
Hello @nguyentype,
I'm Emma, I'm working with Yanone in the GF team. Yanone isn't available this week, so I help him here. The font is now on the API, but we noticed a small issue with accents. See this issue: https://github.com/google/fonts/issues/6226
So I just added anchors to accents and letters, to activate the right feature. See the difference below:
Don't hesitate if you have any questions, once this PR is merged, we will onboard this update asap. Cheers! Emma