Thanks!

[coderschoolreview]

Hi @nguyenvanven

Thanks for your submitting. Good work 👍

In summary, your submission is quite good.

And below are some suggestions that can improve your blog:

• Currently, your navbar didn't work when resizing the browser.
• You can add root route for your site so people can access the root url "https://mighty-cove-28935.herokuapp.com" : root 'articles#index'
• You could have a article about yourself and should not allow users to update/delete the article about yourself.
• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title).
• Articles cannot be deleted on heroku, it's a bug with bootstrap, you have to add the tether gem and add //=require tether in application.js.
• You should display articles with the newest descending order for better usage.
• You can improve the search function so it will not care if it uppercase or lowercase (by turning the search param into lower case string before compare).
• Good point for using bootstrap, you can use it to improve other pages like create, edit.

There is still time, so why don't you work on the remaining optional features this weekend, we will continue to review your submission and provide help if you need. Good work man!

Let us know if you have any questions by commenting here.

[coderschoolreview]

Hi @lxhoang,

Thanks for your submitting. Good work 👍 In summary, your submission is quite good. You have finished all required stories and half of optional stories. And below are some suggestions that can improve your blog:

• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title).
• You could have a article about yourself and should not allow users to update/delete the article about yourself.
• You should display articles with the newest descending order for better usage.
• Good point for using bootstrap, you can use it to improve other pages like detail, create, edit. One small suggest that you should set width: 20rem and using col-sm-offset class to center the article element.
• You can move the html code of the site header and navigation bar from index.html.erb to layout/application.html.erb so navbar and header also display in other views like details, edit view.
• Also render Markdown in detail view, currently it still displays raw text.

There is still time, so why don't you work on the remaining optional features this weekend, especially comments and tags stories so you can understand more about Model association in Rails, we will continue to review your submission and provide help if you need. Good work man! Let us know if you have any questions by commenting here.

Best Regards,

[nguyenvanven]

Hi,

It seem you sent to wrong person :).

Thanks,

On Tue, Feb 7, 2017 at 10:10 PM, coderschoolreview <notifications@github.com

wrote:

Hi @lxhoang https://github.com/lxhoang,

Thanks for your submitting. Good work 👍 In summary, your submission is quite good. You have finished all required stories and half of optional stories. And below are some suggestions that can improve your blog:

• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title).
• You could have a article about yourself and should not allow users to update/delete the article about yourself.
• You should display articles with the newest descending order for better usage.
• Good point for using bootstrap, you can use it to improve other pages like detail, create, edit. One small suggest that you should set width: 20rem and using col-sm-offset class to center the article element.
• You can move the html code of the site header and navigation bar from index.html.erb to layout/application.html.erb so navbar and header also display in other views like details, edit view.
• Also render Markdown in detail view, currently it still displays raw text.

There is still time, so why don't you work on the remaining optional features this weekend, especially comments and tags stories so you can understand more about Model association in Rails, we will continue to review your submission and provide help if you need. Good work man! Let us know if you have any questions by commenting here.

Best Regards,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nguyenvanven/PreworkCoderschool/issues/1#issuecomment-278027974, or mute the thread https://github.com/notifications/unsubscribe-auth/AJiEht_LK9k-TAUDMPde0EjJo3diOiIZks5raIlQgaJpZM4KLrSC .

-- Nguyễn Văn Ven ĐH Khoa Học Tự Nhiên ( 2008)

[lxhoang]

Hi nguyenvanven,

Thanks for review and feedback. I will update those features and inform you if any needed.

Best Regards, Hoang Le

On Wed, Feb 8, 2017 at 7:43 AM, nguyenvanven notifications@github.com wrote:

Hi,

It seem you sent to wrong person :).

Thanks,

On Tue, Feb 7, 2017 at 10:10 PM, coderschoolreview < notifications@github.com

wrote:

Hi @lxhoang https://github.com/lxhoang,

Thanks for your submitting. Good work 👍 In summary, your submission is quite good. You have finished all required stories and half of optional stories. And below are some suggestions that can improve your blog:

• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title).
• You could have a article about yourself and should not allow users to update/delete the article about yourself.
• You should display articles with the newest descending order for better usage.
• Good point for using bootstrap, you can use it to improve other pages like detail, create, edit. One small suggest that you should set width: 20rem and using col-sm-offset class to center the article element.
• You can move the html code of the site header and navigation bar from index.html.erb to layout/application.html.erb so navbar and header also display in other views like details, edit view.
• Also render Markdown in detail view, currently it still displays raw text.

There is still time, so why don't you work on the remaining optional features this weekend, especially comments and tags stories so you can understand more about Model association in Rails, we will continue to review your submission and provide help if you need. Good work man! Let us know if you have any questions by commenting here.

Best Regards,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nguyenvanven/PreworkCoderschool/issues/1# issuecomment-278027974, or mute the thread https://github.com/notifications/unsubscribe-auth/AJiEht_LK9k- TAUDMPde0EjJo3diOiIZks5raIlQgaJpZM4KLrSC .

-- Nguyễn Văn Ven ĐH Khoa Học Tự Nhiên ( 2008)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nguyenvanven/PreworkCoderschool/issues/1#issuecomment-278192862, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHqDYwdoGH9XUScB9tLSCO6ylzz4HGUks5raQ-jgaJpZM4KLrSC .

[lxhoang]

Hi nguyenvanven,

Please see my updated feature based on your review below:

• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title). [Hoang]-> Done
• You could have a article about yourself and should not allow users to update/delete the article about yourself. [Hoang] -> Done
• You should display articles with the newest descending order for better usage. [Hoang]-> Done
• Good point for using bootstrap, you can use it to improve other pages like detail, create, edit. One small suggest that you should set width: 20rem and using col-sm-offset class to center the article element. [Hoang] -> Done
• You can move the html code of the site header and navigation bar from index.html.erb to layout/application.html.erb so navbar and header also display in other views like details, edit view. [Hoang]-> Done
• Also render Markdown in detail view, currently it still displays raw text. -> same with above feedback
• There is still time, so why don't you work on the remaining optional features this weekend, especially comments and tags stories so you can understand more about Model association in Rails. [Hoang]: Complete with comments feature. About tags feature, I'm afraid of I cannot complete it EOD (today is deadline, right?).

Best Regards, Hoang

On Tue, Feb 7, 2017 at 10:10 PM, coderschoolreview <notifications@github.com

wrote:

Hi @lxhoang https://github.com/lxhoang,

Thanks for your submitting. Good work 👍 In summary, your submission is quite good. You have finished all required stories and half of optional stories. And below are some suggestions that can improve your blog:

• Always be cautious with user input, you can use Active Record Validations to validate (like required condition for article title).
• You could have a article about yourself and should not allow users to update/delete the article about yourself.
• You should display articles with the newest descending order for better usage.
• Good point for using bootstrap, you can use it to improve other pages like detail, create, edit. One small suggest that you should set width: 20rem and using col-sm-offset class to center the article element.
• You can move the html code of the site header and navigation bar from index.html.erb to layout/application.html.erb so navbar and header also display in other views like details, edit view.
• Also render Markdown in detail view, currently it still displays raw text.

There is still time, so why don't you work on the remaining optional features this weekend, especially comments and tags stories so you can understand more about Model association in Rails, we will continue to review your submission and provide help if you need. Good work man! Let us know if you have any questions by commenting here.

Best Regards,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nguyenvanven/PreworkCoderschool/issues/1#issuecomment-278027974, or mute the thread https://github.com/notifications/unsubscribe-auth/AGHqDUE0YqlCUzJILEMoby5v2CM6VDzaks5raIlQgaJpZM4KLrSC .