search

nguyer / homeassistant-bond-home

38 stars 15 forks source link

Fix device names #15

Closed nguyer closed 4 years ago

nguyer commented 4 years ago

I'm not sure if this changed in a recent firmware update, or this just got missed in code review/testing, but the device name is actually on the device resource itself, not /properties. Running the current version in master, all my devices just show up as "Fan" or "Light". I also removed appending the "location" to the name, because this is redundant for devices (like I have) named "Office Fan" in the location called "Office". It's necessary to name it "Office Fan" in the Bond app, because they will not let you have multiple devices named "Fan", even if they're in two different rooms / locations.

nguyer commented 4 years ago

@niemyjski Not sure if you want to glance at this real quick to sanity check me here. Thanks!

niemyjski commented 4 years ago

I added that code because there was a location attribute on the devices where you picked the room, so I wanted to prepend that to the names so they were nicer. If that's not working than that is a bug. I think it stinks to have to define a location in bond and then also name your devices that.. It's not clean.

nguyer commented 4 years ago

Yeah I agree with you, but it's just a limitation of the Bond app.

The actual "bug" here though is with the name itself. It's on the device dict, and not in the properties dict. Does that make sense?

Because the previous code was looking in properties, and name wasn't a field there, it was just reverting to calling all my devices "Fan", "Light", etc.

chrismerck commented 4 years ago

On Mon, Feb 24, 2020 at 8:45 AM Nicko Guyer notifications@github.com wrote:

a limitation of the Bond app.

What would be the preferred behavior?

Is it simply a matter of allowing multiple devices with the same name? (We avoid that because it wreaks havoc on Alexa/GH namespaces!)

Also we note that often the name of the room and the natural location-specific prefix are somewhat different: For example, the “Family Room” has a “Family Fan”, not a “Family Room Fan”.

niemyjski commented 4 years ago

I put the room name in all of my devices.. It makes it easy to see where it is in automations. And if a end user doesn't like it they can manually change entity ids easily. It also ensures what we create is unique. Thanks -Blake Niemyjski

On Sat, Feb 29, 2020 at 8:32 AM Chris Merck notifications@github.com wrote:

On Mon, Feb 24, 2020 at 8:45 AM Nicko Guyer notifications@github.com wrote:

a limitation of the Bond app.

What would be the preferred behavior?

Is it simply a matter of allowing multiple devices with the same name? (We avoid that because it wreaks havoc on Alexa/GH namespaces!)

Also we note that often the name of the room and the natural location-specific prefix are somewhat different: For example, the “Family Room” has a “Family Fan”, not a “Family Room Fan”.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nguyer/homeassistant-bond-home/pull/15?email_source=notifications&email_token=AAHZFI3EQKTWRSF3WVKHRELRFEN67A5CNFSM4KZ755L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENL3P3Y#issuecomment-592951279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHZFIZLUPYYE6USGRUR27LRFEN67ANCNFSM4KZ755LQ .