search

nguyer / homeassistant-bond-home

38 stars 15 forks source link

'current_speed' attribute addition #19

Closed MikeFez closed 4 years ago

MikeFez commented 4 years ago

Hello!

I've been using your integration to control my ceiling fans, and it works flawlessly! One issue I've encountered is being able to determine the current speed of the fan for a variety of uses, which in my case is to update an icon on my lovelace dashboard to represent the current setting. This PR integrates the current speed as an attribute, ensuring it's updated when a command is being sent, as well as captured when updating via the bond controller.

Let me know what you think, or if any changes should be made.

niemyjski commented 4 years ago

LGTM

MikeFez commented 4 years ago

Wonderful! I don't have write access to the repo, so I'll let you merge it in. Thanks for the quick response!

niemyjski commented 4 years ago

@nguyer can I get write access :D

niemyjski commented 4 years ago

Thanks for the PR!

nguyer commented 4 years ago

Thanks guys! Appreciate the contributions!