search

nguyer / homeassistant-bond-home

38 stars 15 forks source link

Add GitHub Actions #40

Closed KTibow closed 3 years ago

KTibow commented 3 years ago

I recently announced ha-blueprint: https://community.home-assistant.io/t/made-a-custom-integration-or-card-ive-created-an-all-in-one-github-action-for-you/235041?u=ktibow This makes CI use it.

niemyjski commented 3 years ago

Thanks for the pr. Can you please elaborate what benefit this will add. I checked out the link and it wasn't clear off the bat. Will this test this integration starts up, or is it only linting (if so than it seems overkill to load ha for that) and why does it need a GitHub token.

KTibow commented 3 years ago

It runs Hassfest (to catch invalid integrations), HACS (to catch invalid HACS integrations), and flake8 (to catch invalid python).

niemyjski commented 3 years ago

@nguyer I think we can merge this, I'm a little skeptical about providing a GitHub token without reviewing the add-on source (with my own token). I'm not sure if we should archive this repo now that it's official part of HA

KTibow commented 3 years ago

It's not your own token, it's auto-generated by GitHub.

nguyer commented 3 years ago

Yeah I've actually just switched to using the built in integration. I'm not sure we need this repo at all anymore.

nguyer commented 3 years ago

@KTibow Thanks for your contribution though!

KTibow commented 3 years ago

Might as well clean up stale PRs.