search

nguyer / homeassistant-bond-home

38 stars 15 forks source link

Feature/generic devices #9

Closed bcb2000 closed 4 years ago

bcb2000 commented 4 years ago

Added support for Bond "Generic Devices" - this is the type of control Bond creates if you are using a very basic RF remote controlled switch. Implemented, therefore, as a switch with On and Off controls, and status, and not much else. At the same time, since the command to Bond for turning a generic device on or off is the same as for turning a fan on or off, I renamed bond.turnFanOn and bond.turnFanOff to bond.turnOn and bond.turnOff respectively.

nguyer commented 4 years ago

This is great! I'm wondering about the name changes in bond.py. It makes sense why you changed it, but I'm wondering if turnOn/turnOff are the best names, given that lights have separate functions to control them? Maybe something like turnDeviceOn/turnDeviceOff would be less ambiguous?

bcb2000 commented 4 years ago

Fair point. Perhaps its better even to retain your turnFanOn / turnFanOff as well, even though they would have exactly the same function?

nguyer commented 4 years ago

Closed, due to https://github.com/nguyer/homeassistant-bond-home/pull/11 superseding this PR