ngworker / lumberjack

Chop and cut Angular logs like a professional lumberjack.
https://ngworker.github.io/lumberjack/
MIT License
184 stars 20 forks source link

Fix/sonar smells #157

Closed NachoVazquez closed 1 year ago

NachoVazquez commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Some files still contain remaining logical OR operators (||) instead of the safetier null coalescence operator (??).

What is the new behavior?

All remaining instances of the || operator where replaced with the ?? operator.

Does this PR introduce a breaking change?

[ ] Yes
[x] No
nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 27596390a2a13426fa39aac168a862b5f95acde4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 7 targets - [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/U9uMmeXg4J) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/IFVRm5dV9h) - [`nx affected --target=e2e --parallel=1`](https://cloud.nx.app/runs/SZhlRmyb6E) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/fDGJhI5L86) - [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/eYSmsd4iso) - [`nx affected --target=build --parallel=2`](https://cloud.nx.app/runs/38UlgXBW9i) - [`nx-cloud record -- yarn nx format:check`](https://cloud.nx.app/runs/rt5QEjK5ZE)

Sent with 💌 from NxCloud.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication