ngworker / lumberjack

Chop and cut Angular logs like a professional lumberjack.
https://ngworker.github.io/lumberjack/
MIT License
184 stars 20 forks source link

docs: Updated inject example to show constructor usage #162

Closed ajitzero closed 1 year ago

ajitzero commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Duplicate example in https://ngworker.github.io/lumberjack/docs/usage#using-the-lumberjackservice where both show usage with inject().

Issue Number: N/A

What is the new behavior?

Updated the first example to use the constructor for injection.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fixes #163

nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 2077fa53011d1e63271975dfa64560a3bd0c09d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets - [`nx affected --target=build --parallel=2`](https://cloud.nx.app/runs/34R2EnrsT9) - [`nx affected --target=e2e --parallel=1`](https://cloud.nx.app/runs/407SnOcQZy) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/qmCpQVpZiJ) - [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/AZ7OAUnkgy)

Sent with 💌 from NxCloud.

NachoVazquez commented 1 year ago

Thanks for the PR @ajitzero ! Very appreciated.

I'll take a look right now.

NachoVazquez commented 1 year ago

@all-contributors please add @ajitzero for docs

allcontributors[bot] commented 1 year ago

@NachoVazquez

I've put up a pull request to add @ajitzero! :tada: