ngworker / lumberjack

Chop and cut Angular logs like a professional lumberjack.
https://ngworker.github.io/lumberjack/
MIT License
184 stars 20 forks source link

fix: make rxjs version dynamic to support newest versions of Angular #175

Closed NachoVazquez closed 1 year ago

NachoVazquez commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

RxJS version is fixed at version 7.5.0, which makes it incompatible with the newest version of Angular.

What is the new behavior?

RxJS peerDependency is set to support versions between >= 7.5.0 and < 8.0.0

Does this PR introduce a breaking change?

[ ] Yes
[x] No
nx-cloud[bot] commented 1 year ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0b8e0f2d1d130127fa1dd0546aa15ac3ff24bff1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets - [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/ZOthltT4dE) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/7a7btpiag8) - [`nx affected --target=e2e --parallel=1`](https://cloud.nx.app/runs/slZVj0BxUE) - [`nx affected --target=build --parallel=2`](https://cloud.nx.app/runs/7DhrrmHXgm) - [`nx-cloud record -- yarn nx format:check`](https://cloud.nx.app/runs/6rTXf18FrB)

Sent with 💌 from NxCloud.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here