NachoVazquez commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We support two different APIs: NgModules and Standalone provider* functions to provide our dependencies.

provider* functions are the recommended API, and having both APIs impacts our bundle size.

Fixes: #190

What is the new behavior?

We have deprecated Lumberjack NgModules, and we will remove them in v18.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGES: NgModules are deprecated.

nx-cloud[bot] commented 9 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 331f64b1631b876385e2e3767d52b5c108bbcd6c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

⌛ The following target is in progress

nx affected --target=build --parallel=2

✅ Successfully ran 4 targets

- [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/QPsREdnnkA?utm_source=pull-request&utm_medium=comment) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/l9CvWR8LyJ?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=e2e --parallel=1`](https://cloud.nx.app/runs/TvfsKKnwrB?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- yarn nx format:check`](https://cloud.nx.app/runs/RvvtMQ5psy?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.