NachoVazquez commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We didn't update the Lumberjack peer dependencies when upgrading to Angular 16

What is the new behavior?

We use the proper peer dependencies for Lumberjack and Angular 16

Does this PR introduce a breaking change?

[ ] Yes
[x] No

nx-cloud[bot] commented 9 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3180705fa48c1afb0ae69f56971ae0d17824981e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

- [`nx affected --target=e2e --parallel=1`](https://cloud.nx.app/runs/1OfYm3ELi6?utm_source=pull-request&utm_medium=comment) - [`nx run-many --all --target=test --configuration=coverage --parallel=1 --max-workers=2`](https://cloud.nx.app/runs/iCrAD6Yif6?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=build --parallel=2`](https://cloud.nx.app/runs/DxsltRlfke?utm_source=pull-request&utm_medium=comment) - [`nx run-many --all --target=lint --configuration=report --parallel=2 --max-warnings=0`](https://cloud.nx.app/runs/kpsUu5nfvD?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- yarn nx format:check`](https://cloud.nx.app/runs/dmjH15K4rZ?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.