search

ngx-material-keyboard / core

Onscreen virtual keyboard for Angular ≥ 5 (https://angular.io/) using Angular Material (https://material.angular.io/).
https://ngx-material-keyboard.github.io/core/
98 stars 120 forks source link

Update ngModel and solution for keyboard covering input. #33

Closed digaus closed 6 years ago

digaus commented 6 years ago

Do not know if this is the best way to handle it but it easy and works. Fixes #31 / #32

digaus commented 6 years ago

Added better handling if the text in the input is selected (correct override and deletion) Also added the option to display the input with the keyboard hwen you set an inputTitle. This way one can see the input when the keyboard overlays it. Possible solution for #13 keyboard2

shoudaos commented 6 years ago

@davidenke Will you merge this PR?

zolee commented 6 years ago

@davidenke Hi. Is it possible to merge this PR?

davidenke commented 6 years ago

I'm sorry, this PR covers a lot of things (and maybe also the underlying issue). But please provide a PR that fixes the issue in question and create new issues for any other kind of fixes or features because it's really difficult to review a PR with +100 lines without any recognizable context.

aMedh commented 6 years ago

@digaus do you mind correct your answer like @davidenke suggests? So we can merge it?

"I'm sorry, this PR covers a lot of things (and maybe also the underlying issue). But please provide a PR that fixes the issue in question and create new issues for any other kind of fixes or features because it's really difficult to review a PR with +100 lines without any recognizable context."

digaus commented 6 years ago

Will try when I have the time

davidenke commented 6 years ago

The underlying issue has been fixed in 0.1.0.

aMedh commented 6 years ago

@davidenke we had to make a local clone and removed following line "this.inputValue = this.control.value;" from esm5/ngx-material-keyboard-core.js to make it work.

davidenke commented 6 years ago

Again, the issue should be fixed in 0.1.0.

aMedh commented 6 years ago

This time it works indeed. Wierd. I must have done something completely wrong last time. My apologies.

RaulGF92 commented 6 years ago

I don't know well if @davidenke solved this issue and how can configure the keyboard for can display the cover's inputs under virtual keyboard.

Any can explain me how can use the @davidenke fixes or @digaus solution? Thanks

davidenke commented 6 years ago

@RaulGF92 The mentioned issue is fixed since 0.1.0, but the suggested solution for aiding covered inputs targets a different issue. It'll be great if @digaus would update this PR (or create a new one) containing only the feature based on the current master. Then i'll reopen this PR :)