search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 216 forks source link

DRAFT for discussion - Update ionic to rc.0 and their new tabs #423

Closed captaincaius closed 5 years ago

captaincaius commented 5 years ago

Well, the good news is that lazy loading now works \o/. And the sidemenu routing is still stable.

But here's the bad news - shenanigans are back and ionic's tabs are opinionated as heck. After a tab is selected, it stays alive forever even if you navigate away from it. This is by their design and I couldn't find a workaround.

I can see this seen as a feature for some use cases, but what this means is that if we want to do initialization properly, someone using the ionic tabs version should use a mix of ionic lifecycle hooks and angular ones, and I'm guessing this is contrary to the goals of this project. Our tabs starter doesn't really need any initialization, so maybe we can just leave it to whoever generates a tabs project to deal with that hassle if it affects their use case? I don't know - what do you think?

captaincaius commented 5 years ago

wth? I said release/6.0 :(

sinedied commented 5 years ago

@captaincaius You can edit the base of the PR afterwards if needed