ionic: update to rc1 and fix tabs router and selected tab

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator

https://ngx-rocket.github.io/

MIT License

1.53k stars 216 forks source link

ionic: update to rc1 and fix tabs router and selected tab #428

Closed captaincaius closed 5 years ago

captaincaius commented 5 years ago

tabs finally work nicely in standalone mode with normal angular router and proper lazy loading \o/

minor changes:

ionic tabs shell component more lazy-loading-friendly
app component unit test fix (platform no longer mocked b/c ionic's internals depend on the real thing)
angular dependencies raised to match ionic's (no real difference cause we're using caret anyway)
ionicons added to output in test so tests don't show 404s
build-angular dependency increased so npm audit doesn't cry

sinedied commented 5 years ago

Except for my question, looks good to me good work 👍

BTW it seems they resolved https://github.com/ionic-team/ionic/issues/15956, when the rc2 is out we should be able to remove my workaround

captaincaius commented 5 years ago

Except for my question, looks good to me good work

BTW it seems they resolved ionic-team/ionic#15956, when the rc2 is out we should be able to remove my workaround

thanks :)

ok... we're gonna merge this first though right?