search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 217 forks source link

doc: build-specific configuration options (fix #475) #476

Closed captaincaius closed 5 years ago

captaincaius commented 5 years ago

Thanks for this great guide

I think the tl;dr section is a bit long and could go more straight to the point (and best practice), but this is a very good doc overall!

(I just made some cosmetics edit to improve readability a bit)

:D lol the tl;dr needs its own tl;dr

Thanks for the feedback and edits! I'll make time for it this week.

captaincaius commented 5 years ago

Thanks for taking the time to read it and help!

I hope this last commit was a step in the right direction. I tried making the tl;dr more to the point, and I think it got clearer, but also longer :(.

LMK if you have any other ideas.

sinedied commented 5 years ago

The last changes are 👍 , with just a small change I would prefer before merging: I think replacing yarn <cmd with npm run <cmd would be better for a doc, even though we support both NPM is the default installed PM for Node.js and the other docs also use it as a ref. I think Yarn users easily makes the translation, while the other it might not be obvious for people just starting in the ecosystem 😉

captaincaius commented 5 years ago

shoot i missed that yarn reference. good catch. will fix today.