Add Angular 8 support (close #478)

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator

https://ngx-rocket.github.io/

MIT License

1.53k stars 216 forks source link

Add Angular 8 support (close #478) #481

Closed sinedied closed 5 years ago

sinedied commented 5 years ago

Additional notable changes:

Enable lazy loading by default
Migrate services to use providedIn
Add @ionic-native/keyboard package for Cordova target
Disable AOT for serve task, to speed up rebuilds

alexartwww commented 5 years ago

Waiting for this release

galenp commented 5 years ago

I'm getting a compilation error with angular 8.0.2 that I don't think was occurring in 8.0.0.

ERROR in ./src/app/core/http/http.service.ts 30:12-27 "export 'HttpInterceptor' was not found in '@angular/common/http'

Might want to check that this PR is using 8.0.2 and is compiling successfully.

sinedied commented 5 years ago

This one migration has been particularly awful, and it's not even enabling Ivy or new lazy-loading system (tried it, didn't work 🤣). Hopefully this will me mergeable soon🤞

sinedied commented 5 years ago

Finally! 🎉 🍾 🎊 😃 Seems that CI flakyness (#480) with Ionic 4 also solved itself with the upgrade 😎