search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 217 forks source link

Add Jest option #486

Closed creal73 closed 5 years ago

creal73 commented 5 years ago

As Jest is popular in web community, here is an integration proprosal in ngx-rocket.

Your feedbacks are welcome :)

sinedied commented 5 years ago

There's some errors in the CI, can you take a look?

creal73 commented 5 years ago

I will check the CI after the weekend. Tomorrow is a special day for me 🎂🥳

sinedied commented 5 years ago

Seems like the jest config has to be updated a bit as it does not take in account the @env/@app path alias, maybe that's because some tsconfig files have changed location following the angular 8 upgrade.

creal73 commented 5 years ago

Yep, I seen it yesterday. I already rebased the branch onto master.

I will fix the issues when during my next free time :)

creal73 commented 5 years ago

@sinedied Any idea about the following CI error ?

sinedied commented 5 years ago

Hmm seems only the android builds are failing, my last quick CI update seems to have broken something, otherwise LGTM (comments I made can be for another PR) 👍

sinedied commented 5 years ago

@bursauxa No need to update the changelog manually, it's currently done by github_changelog_generator, but I'm thinking to migrate to conventional commits for an even better solution 😉