Analytics error fallback, fix opt-out

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator

https://ngx-rocket.github.io/

MIT License

1.53k stars 216 forks source link

Analytics error fallback, fix opt-out #495

Closed RAMOhio closed 5 years ago

RAMOhio commented 5 years ago

Fixed the analytics opt-out functionality to check if the user has opted out before using Insight library for analytics. Checks if something in the Insight library failed (i.e. on initialization) and if so, trip the no-analytics flag.

sinedied commented 5 years ago

I think the lint part is missing in the contribution guide, I need to update it later my bad 🐳

RAMOhio commented 5 years ago

I've learned that I know even less about git through the CLI than I thought... I think I've got everything figured out though, opening another pull request here in a sec with the comments fixed. Thanks for the info, learned some new things about JS today (I still suck at JS, but hey, learning is fun lol)