Disable puppeeter for unit tests by default

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator

https://ngx-rocket.github.io/

MIT License

1.53k stars 217 forks source link

Disable puppeeter for unit tests by default #522

Closed sinedied closed 4 years ago

sinedied commented 4 years ago

Seems that a chromedriver update has broken the CI :( https://sinedied.visualstudio.com/oss-pipelines/_build/results?buildId=156

Probably just a matter of updating project dependency, but might be useful to check the root cause.

sinedied commented 4 years ago

Ok, the latest chromedriver update requires a newer Chrome version than the latest one supported by puppeeter :/ Meanwhile puppeeter gets a compatible update, I'll go for making using an external chrome install the default one, and add an option for pupeeter in optional tooling. It will also make default installs way faster as a nice side effect 😉

sinedied commented 4 years ago

:tada: This issue has been resolved in version 8.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: