search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 216 forks source link

feat: remove HttpService and CacheService #534

Closed sinedied closed 4 years ago

sinedied commented 4 years ago

BREAKING CHANGE: Removing HttpClient overload as this is definitely not something the Angular team is looking to support. Also it's not relevant and useful anymore thanks to state management libraries, that's why CacheService is also removed.

sinedied commented 4 years ago

:tada: This PR is included in version 8.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

charlypeluch commented 3 years ago

Hello @sinedied,

I have been using this solution, but recently I have encountered a conflict with the MatIconRegistry module. This module internally uses httpClient to retrieve SVG.

Could you tell me which third-party solutions you have tried, which one best suits the use case that covered this functionality, and where can I find documentation to integrate it? Thank

sinedied commented 3 years ago

Hi @charlypeluch, I'm not sure I understand what your issue is here?

What what removed was an extension of the build-in HttpClient module, but the original HttpClient module can still be used. If it's the extension causing issue, it's most likely caused by the ApiInterceptor adding the extension prefix: in that case, have a look at the file https://github.com/ngx-rocket/generator-ngx-rocket/blob/e9d2fd536d9b4e2768d7c3cecf6069981f83d89d/generators/app/templates/src/app/core/http/api-prefix.interceptor.ts to avoid adding the API prefix when retrieving SVG icons.