ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 217 forks source link

Move authentication service/guard to dedicated auth module #535

Closed sinedied closed 4 years ago

sinedied commented 4 years ago

Having the auth services in core module seems to harmful and not easily understood by everyone, seeing all issues around it, especially due to imports loops and http service extension.

To remediate that, I propose to move all auth related services to a dedicated auth module, that will also contain the login page and components.

sinedied commented 4 years ago

:tada: This issue has been resolved in version 8.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: