search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 218 forks source link

Add notranslate tag to index.html #549

Closed fabiomartino closed 3 years ago

fabiomartino commented 4 years ago

Hi. Let me explain the reason for this PR.

When I create a new application, in the classic way (Angular CLI) or with ngx-rocket, one of the first configurations that I make is to disable the translation offered by Google Chrome. notranslate01 Nowadays "automatic" translations are quite precise but they are not perfect, and this is the reason why automatic translation should be disabled.

I added a simple prompt option that ask to include this tag in the index.html (default to NO) notranslate

If the condition apply then the tag will be added notranslate3

Cordially Fabio

bursauxa commented 4 years ago

I am not sure about that notranslate thing. For sure I would better understand a page in Italian if it was translated into English, even by Google automatic translator.

Your problem seems to be that Chrome translates pages from English to Italian, and you do not want that because your English is better than Chrome's translation to Italian. To me, that is an issue on your side: you should set Chrome to never translate pages written in English (as I did).

fabiomartino commented 4 years ago

I am not sure about that notranslate thing. For sure I would better understand a page in Italian if it was translated into English, even by Google automatic translator. try to be more specific Your problem seems to be that Chrome translates pages from English to Italian, and you do not want that because your English is better than Chrome's translation to Italian. To me, that is an issue on your side: you should set Chrome to never translate pages written in English (as I did).

Hi... I try to be more specific... On my side as developer of course the better option is provide a full translated app in all the possible target languages (In my case usually English and Spanish)... but the final user? (Is not a big deal to ask everyone to disable it on his side)

Some client asked me if would be possible to disable this "annoying" request made by Chrome to translate the content... and this is I think is the easy solution referenced here

Cordially

sinedied commented 4 years ago

I agree with @bursauxa here, I don't think this is something we want to push for everyone, though I understand your logic here.

Keep in mind that even if it can be "annoying" for some users (it can be disabled easily on the user browser though) this is an important accessibility feature for a lot of users out there, and as such I don't think it makes it should be done by default.

If you want this to be enabled on all yours apps, you can always make it an add-on so you don't get bother adding this tag everytime.