search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 218 forks source link

translations:extract didn't work for .ts files #551

Closed Achraf-vermeg closed 3 years ago

Achraf-vermeg commented 4 years ago

I'm submitting a...

Current behavior

npm run translations:extract

didn't extract strings between extract('Hello') from ts files

Expected behavior

Should have string Hello in src\translations\template.json

Minimal reproduction of the problem with instructions

Add extract('Hello') in any ts file (component, module,...)

npm run translations:extract

Environment

ngx-rocket@8.0.1
sinedied commented 4 years ago

It seems that https://github.com/biesbjerg/ngx-translate-extract has changed the way markers work, you now have to import a specific function from their package 😞

sinedied commented 3 years ago

:tada: This issue has been resolved in version 9.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: