feat: upgrade the generate app to be Angular 12 #600

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator

https://ngx-rocket.github.io/

MIT License

1.53k stars 216 forks source link

feat: upgrade the generate app to be Angular 12 #600 #601

Closed patelvimal closed 3 years ago

sinedied commented 3 years ago

Thanks for the PR!

I saw that e2e tests were removed from the default CLI template, though I would prefer to keep it here as an option as this generator is oriented towards enterprise apps which needs e2e tests most of the time.

I'll merge this in the ng12 work branch in the meanwhile, so I can also have a look at why the tests are failing (probably related to e2e removal).

patelvimal commented 3 years ago

Protector e2e is removed from angular 12 version. That's why I removed it.

sinedied commented 3 years ago

Yes, saw that. I'll use your PR as a basis to make it optional in the next release 🙂

patelvimal commented 3 years ago

ok, thanks, let me know how can I contribute more or do you have any other interesting angular project to contribute?