search

ngx-rocket / generator-ngx-rocket

:rocket: Extensible Angular 14+ enterprise-grade project generator
https://ngx-rocket.github.io/
MIT License
1.53k stars 219 forks source link

refactor: jest.config paths generation at runtime #610

Closed yashanand1910 closed 2 years ago

yashanand1910 commented 2 years ago

By using a simple function provided by ts-jest/utils, we can remove the need to manually update the jest.config every time a new path is added to tsconfig.json

yashanand1910 commented 2 years ago

Didn't know a single comment could cause an issue that'd take me an hour to debug. Well, JSON does not support comments and I have removed the one from _tsconfig.json at least as it will be imported.

yashanand1910 commented 2 years ago

Hey @sinedied, I am confused why the last check failed. Could you have a look?

sinedied commented 2 years ago

Sorry for the delay, it seems the mobile builds (once again) have an issue, unrelated to your PR. I had the chance to test your changes in a different project, so I'll merge this as-is and will fix the CI separately. Thanks!

ci-rebot commented 2 years ago

:tada: This PR is included in version 10.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: