Did a "core" folder get replaced by the "shared" folder?

[mattseaboard]

I'm submitting a...

• [ ] Bug report
• [ ] Feature request
• [ ] Documentation issue or request
• [X] Question

I have a question about the file/folder structure of the generated projects. Did there used to be a "core" folder which got replaced by the "shared" folder? In the logging service I see this comment, but this path does not exist:

* import { Logger } from 'app/core/logger.service';

Was the core folder replaced with the shared folder? If so, can someone explain the reason for this? I'm just curious about how to organize my multiple services and other components that i consider to be "core" and "shared".

Thanks!

[mattseaboard]

I see in the commit history for the ReadMe that core was indeed replaced by shared 4 months ago. What was the reasoning for this? Just curious because this is helpful in my understanding of how the project is structured/architected, thanks!

[sinedied]

Yes, only the shared folder remains now as it's been a few versions since a core module is no longer a recommender practice in the Angular style guide. Previously, the goal of the core module was to regroup services where only 1 global instance shared across modules was wanted. But with the new providedIn syntax introduced, services no longer need to be part of a module and this initial problem the core modules was solving does not exist anymore. So only shared remains, and it's now fine to put shared services in there too.