ngx-translate / http-loader

A loader for ngx-translate that loads translations with http calls
MIT License
191 stars 69 forks source link

Use relative path so that we properly apply --base-href. #61

Open SamuelMS opened 5 years ago

SamuelMS commented 5 years ago

Re-implements changes from #12, since they were backed out due to failing tests.

@ocombe Would you mind reviewing when you get a moment? Thanks!

sergio-new-developer commented 5 years ago

I have the same problem..

MickL commented 5 years ago

I just wanted to make the exact same pull-request. You might add changes to README.md, too. Nearly one year later, why is it not merged?

There is no reason for having a hardcoded path.

MickL commented 5 years ago

@ocombe please accept