Does not work with angular 18.0.5

beig commented 4 months ago

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Cant install into project

npm ERR! Found: @angular/common@18.0.5
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^18.0.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^17.0.0" from @ngxpert/avvvatars@1.0.0
npm ERR! node_modules/@ngxpert/avvvatars
npm ERR!   @ngxpert/avvvatars@"*" from the root project

Expected behavior

Support Angular 18 (and upcoming 18.1)

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

I forked the project and tried to update

in projects/ngxpert/avvvatars/package.json

    "@angular/common": ">=17.0.0 <=18.0.5",
    "@angular/core": ">=17.0.0 <=18.0.5"

and then in package.json angular, eslint, typescript to the latest version but I get

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @ngxpert/avvvatars@0.0.0-development
npm ERR! Found: @angular-devkit/build-angular@17.0.6
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev @angular-devkit/build-angular@"^18.0.6" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev @angular-devkit/build-angular@"^18.0.6" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@5.4.5
npm ERR! node_modules/typescript
npm ERR!   peer typescript@">=5.4 <5.5" from @angular-devkit/build-angular@18.0.6
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"^18.0.6" from the root project

Environment


Angular version: 18.0.5


For Tooling issues:
- Node version: v22.3.0  
- Platform:  Windows

Others:

beig commented 2 months ago

So I guess this project is dead?

shhdharmen commented 2 months ago

I am running a bit busy. PR is welcome for this fix! I think this simply needs an ng update.

beig commented 2 months ago

I am running a bit busy. PR is welcome for this fix! I think this simply needs an ng update.

thanks for your work, as shown, i have tried to update, but i am stuck in a dependency hell after updating

shhdharmen commented 2 months ago

@beig I meant this library needs updating to angular 18.

github-actions[bot] commented 2 months ago

:tada: This issue has been resolved in version 2.0.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ngxpert / avvvatars