ngxpert / hot-toast

🍞 Smoking hot toast notifications for Angular.
https://ngxpert.github.io/hot-toast/
MIT License
73 stars 7 forks source link

[Fix] Toast message not being removed automatically #17

Closed rajanchavda closed 2 months ago

rajanchavda commented 2 months ago

Added static:true as the viewchild sometimes unable to access the tag. Also replaced cdr.detectChanges() with cdr.markForCheck()

fix #16

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 16

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

rajanchavda commented 2 months ago

@shhdharmen Can you please review this ? Thanks !!

shhdharmen commented 2 months ago

:tada: This PR is included in version 3.0.1-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: