feat: make inputs signal based - Githubissues

ngxpert / hot-toast

🍞 Smoking hot toast notifications for Angular.

https://ngxpert.github.io/hot-toast/

MIT License

68 stars 6 forks source link

feat: make inputs signal based #8

Open deepakrudrapaul opened 3 months ago

deepakrudrapaul commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Current Inputs are not signal based

Issue Number: #6

What is the new behavior?

Inputs are updated to signal based

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This pull request is specifically for input-based signals. I will submit a separate pull request for output-based signals.

shhdharmen commented 3 months ago

This MR has lot more issues than expected. @deepakrudrapaul please test all the variants of toast carefully.