ngxs-labs / actions-executing

MIT License
27 stars 5 forks source link

actions-executing plug-in is not working as expected with nx monorepo ! #15

Open HD60Hz opened 2 years ago

HD60Hz commented 2 years ago

We recently moved our Angular project into a monorepo (nx). we noticed that the action execution plugin no longer works! are there any special configurations when it comes to using this kind of architectures, especially with shared libraries etc. ?

joaqcid commented 1 year ago

hi @HD60Hz i use this plugin myself with Nx without any issues, can you be more specific what issue you are having?

btw, sorry for late response

joaqcid commented 1 year ago

closing the issue, if you still are having problem please post more details and if possible a stackblitz with the error repro.

thanks @HD60Hz

MahmoudTarekAli commented 1 month ago

Facing the Same issue here after i moved my angular project to nx workspace the action execution plugin no longer works! it always returns false and doesn't detect the changes which should be false => true => false and hasActionsExecuting return undefined


   this.store
      .select((state) => state['hasActionsExecuting'])
      .subscribe((data) => {
        console.log('Actions Executing:', data);
      });
joaqcid commented 1 month ago

hi @MahmoudTarekAli

that is not how you are supposed to use the actionExecuting plugin

Please refer to the documentation

But generally speaking you would this.store.select(hasActionsExecuting([ACTION]))

MahmoudTarekAli commented 1 month ago

Okay but I am also using the @select decorator but facing the same issue, so is this not working anymore ?

@Select(hasActionsExecuting([GetFeaturedArenas])) getFeaturedArenasIsExecuting$: Observable;

MahmoudTarekAli commented 1 month ago

and after using this this.store.select(hasActionsExecuting([ACTION]))

it also keeps return only false not false => true => false

joaqcid commented 1 month ago

@MahmoudTarekAli yes, the plugin works with NX, my project uses nx version 17 and works ok.

what versions of nx, ngxs and actions-executing plugin are you using?

would you be able to create a repo with a reproducible error?

joaqcid commented 1 month ago

@MahmoudTarekAli @HD60Hz NX shouldnt change anything about how this plugin works, the only thing i would make sure is what angular version you are using and making sure is aligned with the ivy or non-ivy version of the plugin

joaqcid commented 3 weeks ago

@MahmoudTarekAli you still have issue with this?