search

ngxs-labs / data

NGXS Persistence API
https://ngxs-labs.github.io/data
81 stars 18 forks source link

@angular-ru as a peer dependency? Why? #630

Closed gioele-antoci closed 3 years ago

gioele-antoci commented 3 years ago

I am having issues with running the persistance module

Error: ./node_modules/@ngxs-labs/data/fesm2015/ngxs-labs-data-repositories.js Module not found: Error: Can't resolve '@angular-ru/common/utils' in './node_modules/@ngxs-labs/data/fesm2015'

Until I noticed @angular-ru is a peer dependency: https://github.com/ngxs-labs/data/blob/master/lib/package.json#L34

Why would that be the cause? Why not official angular repositories? What am I missing? Do I actually need to install whatever angular-ru is?

splincode commented 3 years ago

Because this project will be move to @angular-ru/ngxs-data and deprecated @ngxs-labs/data

gioele-antoci commented 3 years ago

Does this mean that I unless I intend to install @angular-ru I won't be able to use the persistence API? What's the reason to deprecate it from here?

splincode commented 3 years ago

because this project is easiest to maintain in another repository where automatic publishing of projects is configured

oglezglez commented 3 years ago

You are using this dependency mainly for types definition... as far I see, there is no reason to not use official Angular repositories... and it's not documented... and why? Do you think it could be fixed?

splincode commented 3 years ago

@oglezglez me and my team are working to improve the shared library (@angular-ru/common)

in the future this package will be moved and delivered this way

{
  "dependencies": {
    "@angular-ru/common": "....",
    "@angular-ru/ngxs-data-plugin": "....",
  }
}
ivanblazevic commented 3 years ago

@oglezglez me and my team are working to improve the shared library (@angular-ru/common)

in the future this package will be moved and delivered this way

{
  "dependencies": {
    "@angular-ru/common": "....",
    "@angular-ru/ngxs-data-plugin": "....",
  }
}

I am not planning to install some strange Russian fork of Angular into my project just for the purpose of having this plugin - after seeing this and the direction where it is going and the thought process of its maintainers for me this is clear sign to removing this library from my project and switching back either to ngrx or some alternative.

splincode commented 3 years ago

@ivanblazevic up to you))

NGXS Labs is group for experimental projects, but it is my own project)) and data-plugin has nothing to do with the NGXS core and is supported by me personally

splincode commented 3 years ago 
{
  "dependencies": {
    "@angular-ru/cdk": "....",
    "@angular-ru/ngxs": "....",
  }
}