search

ngxs-labs / entity-state

⏱ WIP: Entity adapter
48 stars 12 forks source link

Library's peerDependencies #10

Closed eranshmil closed 5 years ago

eranshmil commented 5 years ago 
{
  "name": "entity-state",
  "version": "0.0.1",
  "peerDependencies": {
    "@angular/common": "^7.0.0",
    "@angular/core": "^7.0.0",
    "@ngxs/store": "^3.3.0"
  }
}

There's a reason why not support angular 6 and older ngxs versions?

JanMalch commented 5 years ago

Had Angular 6 as a peer dependency until 940de87. Tests didn't run. Bumping the Angular version fixed it. @ngxs/store dependency is a good point. How far down would you go, when it's running?

eranshmil commented 5 years ago

Did you figure out why it was failing and why the upgrade fixed that? Maybe it can be solved other way.

About NGXS, my guess it will work no matter what, but in my opinion, it will be enough to support all 3.x versions. And of course, it needs to be checked.

markwhitfeld commented 5 years ago

Although it would be great to support all 3.x versions I think that it would be safe to assume that anyone using this library is probably just setting up or is happy to upgrade. Regarding the Angular 7 dependency I think that is important to investigate

NarHakobyan commented 5 years ago

test failure reason was Jasmin types version, I have fixed it and opened a PR https://github.com/ngxs-labs/entity-state/pull/11

eranshmil commented 5 years ago

Great! But you don't have to revert the main package.json, only the peerDependencies.

NarHakobyan commented 5 years ago

@eranshmil yes you are right, I have removed it :)

JanMalch commented 5 years ago

What's the usual (CI) procedure for testing support of dependency versions? I mean I can't just lower the version number without confirming that it works with both ng6 and ng7 in the integration test?

NarHakobyan commented 5 years ago

need to create separate tags and branches for each angular version, for example, entity-state@6 -> angular6 entity-state@7 -> angular7 and I think need to be maintained only last version

eranshmil commented 5 years ago

I guess this issue isn't relevant anymore.