search

ngxs-labs / firestore-plugin

Firestore plugin for NGXS
https://ngxs-firebase-plugin.netlify.com/
MIT License
20 stars 14 forks source link

Firebase update version #83

Closed SanchoPanzaaa closed 4 months ago

SanchoPanzaaa commented 1 year ago

Hi there, I really like the repository, but as I'm using the latest angular and though I need latest firebase app and I would really appreciate update to the version firebase 10, otherwise unexpected outcomes happens.

Is it comming any time soon ?

Need some help ?

Feel free to write me,

thank you Richard

joaqcid commented 1 year ago

hi @SanchoPanzaaa do you get an error when using firebase 10?

JGSolutions commented 1 year ago

Actually angularfire released version 16. When performing a npm install i get dependancy errors

Could not resolve dependency: npm ERR! peer @angular/fire@">=7.0.0 <8.0.0" from @ngxs-labs/firestore-plugin@1.2.8

JGSolutions commented 11 months ago

Any progress on this?

JGSolutions commented 11 months ago

Unfortunately we will be removing this plugin from our project. Very difficult for us to upgrade to ang v17 as this plugin is causing dependancy issues.

joaqcid commented 11 months ago

@JGSolutions ill be working in the next two weeks to make it compatible with latest version of angular 17, would be able to tell me what errors you get when upgrading? are you just upgrading angular 17 or angular/fire too?

JGSolutions commented 11 months ago

Yes we updated to angV17 back in Oct. Also updated to the latest ang/fire v17 which then this plugin caused dependency issues.

Just create a ang17 project with latest angular/fire and which you will reprroduce the issue

joaqcid commented 10 months ago

hi @JGSolutions

i created a project with the following deps and it works for me, can you send me the lib versions you are using when it doesnt work?

@angular/*: "17" @ngxs/store: "3.8.2" "@ngxs-labs/firestore-plugin": "^1.2.8" "@angular/fire": "^17.0.0" firebase": "^10.7.1

JGSolutions commented 10 months ago

hi @joaqcid

Remove the firebase": "^10.7.1 I didn't have that but again I can't reproduce it as I removed the plugin. I want my app to be less dependant on plugins

joaqcid commented 10 months ago

ah ok, but if you want to use firebase, you need to have that library...

JGSolutions commented 10 months ago

ahh ok i see. Wouldn't your plugin install the firebase sdk?

joaqcid commented 10 months ago

no, you need to install those yourself, along with the plugin you need to install firebase and @angular/fire