Initial State is not flushed to the storage on the first page load (localStorage used)

[un33k]

[x] Bug

Versions

    "@ngxs/devtools-plugin": "^2.0.0-rc.24",
    "@ngxs/logger-plugin": "^2.0.0-rc.24",
    "@ngxs/storage-plugin": "^2.0.0-rc.24",
    "@ngxs/store": "^2.0.0-rc.22",
    "@angular/core": "5.2.9",

Repro steps

• Clean localStorage
• Reload page
• Verify that localStorage doesn't have your key:value (bug)
• Dispatch an action
• Verify that localStorage has your key:value (expected)

Observed behavior

Initial page load doesn't create an initial state in localStorage.

Desired behavior

  // storage.plugin.ts
  if (isInitAction) {
      for (const key of keys) {
        let val = this._engine.getItem(key);

        if (val !== 'undefined' && val !== null) {
          val = options.deserialize(val);

          if (key !== '@@STATE') {
            state = setValue(state, key, val);
          } else {
            state = val;
          }
        } else {
           this._engine.setItem(key, options.serialize(state));     // <- here (possible solution)
        }
      }
    }

[amcdnl]

Is this still an issue?

[un33k]

@amcdnl tested it, handles it gracefully now.