Closed arturovt closed 4 months ago
Total files change +152B +0.11%
Final result: :white_check_mark:
View report in BundleMon website ➡️
Code Climate has analyzed commit 19c4b4f9 and detected 1 issue on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Complexity | 1 |
The test coverage on the diff in this pull request is 91.7% (50% is the threshold).
This pull request will bring the total coverage in the repository to 95.2% (0.0% change).
View more on Code Climate.
And just wondering if the original issue is represented in a test?
The original issue was that the error handler was not being called on each error. We've decided not to support this anymore because it's strange to log errors even if they're handled. For instance, if someone is using Rollbar and providing their custom ErrorHandler
which logs errors to Rollbar, even handled errors would be logged to Rollbar, which is completely undesirable.
☁️ Nx Cloud Report
CI is running/has finished running commands for commit 19c4b4f9d20db3fcfde0872700d1bfc1c404a948. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
- [`nx lint-types store`](https://cloud.nx.app/runs/PY5wMdsaDH?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test --all --configuration=ci --maxWorkers=4`](https://cloud.nx.app/runs/0e7h0UckyN?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/6wNZwK9AXx?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/PiutxsZOQP?utm_source=pull-request&utm_medium=comment)Sent with 💌 from NxCloud.