ngxs / store

🚀 NGXS - State Management for Angular
http://ngxs.io
MIT License
3.52k stars 400 forks source link

refactor(store): rely on `ngDevMode` to be always defined #2138

Closed arturovt closed 4 months ago

arturovt commented 4 months ago

This commit updates all ngDevMode conditions to remove the check for ngDevMode being undefined. We can ensure it's always defined by Angular since VE has been dropped. However, the typeof check is still necessary to ensure code safety, as ngDevMode is a global variable provided by the framework.

nx-cloud[bot] commented 4 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6bbdf0df360dc28f2bd0881a6b5843d4cf663c8b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx run-many --target=test --all --configuration=ci --base=remotes/origin/master --head=HEAD`](https://cloud.nx.app/runs/V42xCpP2Zs?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=lint --all --configuration=ci --base=remotes/origin/master --head=HEAD`](https://cloud.nx.app/runs/YjpW8Bfwd9?utm_source=pull-request&utm_medium=comment) - [`nx lint-types store`](https://cloud.nx.app/runs/5Pl0qScQlC?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/GA1DSTFdOi?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test --all --configuration=ci --maxWorkers=4`](https://cloud.nx.app/runs/40cgMa7dEC?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/aC1SoXiGWS?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

bundlemon[bot] commented 4 months ago

BundleMon (Integration Projects)

Files updated (1) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
| 66.94KB (+17B +0.02%) | +1%
Unchanged files (1) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
| 68.43KB | +1%

Total files change +11B +0.01%

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

codeclimate[bot] commented 4 months ago

Code Climate has analyzed commit 6bbdf0df and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.