Closed profanis closed 6 months ago
CI is running/has finished running commands for commit 09418a48a0676309dda620cb89abd5121957b80d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Total files change +9B +0.01%
Final result: :white_check_mark:
View report in BundleMon website ➡️
We need to update the docs references in the deprecation doc comments in the actual code too.
@markwhitfeld I am afraid I didn't get what needs to be fixed.
I think Mark refers to this code:
And for children
too
We need to update the docs references in the deprecation doc comments in the actual code too.
I updated the doc references @markwhitfeld
Code Climate has analyzed commit 09418a48 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 95.2% (0.0% change).
View more on Code Climate.
The reason for this change is the following:
Let's assume a developer works in a company where they decide to migrate to the version where the select decorator is deprecated. Although it's being deprecated they might need some time to convert their code. At the same time, they might need/want to read about the select decorator. If we completely remove the docs, it's harder for them to find the information they are looking for