Closed ConnorUllmann closed 5 months ago
CI is running/has finished running commands for commit a9f4ff32f245ff2a24de189ff49c1432d4698a45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
Total files change -3B 0%
Final result: :white_check_mark:
View report in BundleMon website ➡️
Code Climate has analyzed commit a9f4ff32 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 95.3% (0.0% change).
View more on Code Climate.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
@Action
decorator does not enforce that the actions passed to the decorator match the payloads expected by the method it decorates.A simple example is the following—the below action has a payload
{ value: string }
but the handler expects{ value: number }
incorrectly. This does not produce an error.Issue Number: N/A
What is the new behavior?
In the above example, a type error occurs. The case of multiple actions is also handled, requiring that a union of the payloads is accepted by the method.
Does this PR introduce a breaking change?
This change is likely to introduce type errors, but it is not intended to impact runtime behavior.