ngxs / store

🚀 NGXS - State Management for Angular
http://ngxs.io
MIT License
3.52k stars 400 forks source link

docs: use the new logo #2163

Closed profanis closed 2 months ago

profanis commented 2 months ago

Logo in Dark theme image

Logo in Light theme image

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b70d559fcde733bf13ac05397378605c81df81c3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets - [`nx run-many --target=lint --all`](https://cloud.nx.app/runs/JxATR2ZwmX?utm_source=pull-request&utm_medium=comment) - [`nx lint-types store`](https://cloud.nx.app/runs/6FOS2OfxGB?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=test --all --configuration=ci --maxWorkers=4`](https://cloud.nx.app/runs/l78aT0N6eh?utm_source=pull-request&utm_medium=comment) - [`nx run-many --target=build --all`](https://cloud.nx.app/runs/ckDiKaOZPy?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

bundlemon[bot] commented 2 months ago

BundleMon (Integration Projects)

Unchanged files (2) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
| 68.5KB | +1% :white_check_mark: | Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
| 67.03KB | +1%

No change in files bundle size

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

markwhitfeld commented 2 months ago

@profanis I think it might be better to describe the appropriate usage of the logo in the file name instead of the colour combinations. Also, let's keep the file names lower case to avoid OS issues. Could we rename the files: NGXS-Logo_White_Blue.png -> ngxs-logo_dark_theme.png NGXS-Logo_Black_Blue.png -> ngxs-logo_light_theme.png

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit b70d559f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3% (0.0% change).

View more on Code Climate.