ngxs / store

πŸš€ NGXS - State Management for Angular
http://ngxs.io
MIT License
3.52k stars 400 forks source link

🐞[BUG]: List of breaking changes or how to update to ngxs 18 #2176

Open rbirkgit opened 1 month ago

rbirkgit commented 1 month ago

Affected Package

ngxs 18

Is this a regression?

Description

I cannot find any information of any breaking changes in ngxs 18 or how to update to it. I tried just updating the versions but getting compile errors with signature changes.

πŸ”¬ Minimal Reproduction

Updating my project form 3.8.2 to 18.0.0

πŸ”₯ Exception or Error


Error: libs/automation-shell/src/lib/store/automation-sub-service.state.ts:36:4 - error TS1270: Decorator function return type 'void | DescriptorWithNoInjectedState<[typeof AutomationSubServiceState, (state: AutomationEnvironmentStateModel) => boolean, (routerState: RouterStateModel) => string | undefined, (state: CspStateModel) => CspSubServiceMap | undefined, (state: IdentityStateModel) => CspSubServiceMap | ...' is not assignable to type 'void | TypedPropertyDescriptor<(state: AutomationSubServiceStateModel, isOnPrem: boolean, servicePath: string, cspAccessableSubServiceMap: CspSubServiceMap, identityAccessableSubServiceMap: CspSubServiceMap) => AutomationSubService | undefined>'.

Environment


Libs:
- @angular/core version: 17.3.10
- @ngxs/store version: 18.0.0

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 20.13.0
- Platform:  Windows

Others:

hakimio commented 2 weeks ago

The upgrade guide is here. I don't know why @markwhitfeld hasn't officially published it yet.

EDIT: maybe because of #2179

markwhitfeld commented 2 weeks ago

Yes, the NGXS v18 launch has been a "soft launch" so far. We are getting early feedback (like the issue above) and looking at where our documentation and release announcement can be improved before publicising the release.