Closed arturovt closed 6 days ago
CI is running/has finished running commands for commit 456efc0c3fc84f3858bab08062a84dfa5e5173a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
``` yarn add https://pkg.pr.new/@ngxs/devtools-plugin@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/form-plugin@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/hmr-plugin@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/router-plugin@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/storage-plugin@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/store@2262.tgz ```
``` yarn add https://pkg.pr.new/@ngxs/websocket-plugin@2262.tgz ```
commit: 456efc0
Total files change -1.04KB -0.8%
Final result: :white_check_mark:
View report in BundleMon website ➡️
No change in files bundle size
Final result: :white_check_mark:
View report in BundleMon website ➡️
Total files change -264B -0.13%
Final result: :white_check_mark:
View report in BundleMon website ➡️
Code Climate has analyzed commit 456efc0c and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 95.3% (0.0% change).
View more on Code Climate.
In this commit, we mark the state factory as a root provider to prevent its initialization at feature levels when
provideStates
is called.Previously, the state factory was initialized at feature levels because it needed to retrieve the feature-level injector in order to call
injector.get(FeatureStateClass)
. This was necessary because, whenNgxsModule.forFeature([BlogState])
was called, theBlogState
instance could only be retrieved from the feature injector hierarchy.Now, since
addAndReturnDefaults
is called at the feature level inside the feature environment initializer, it is executed within the feature injection context, allowing us to use theinject(...)
function directly.