search

ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
581 stars 85 forks source link

refactor: use Proxy in toObservableSignal() instead of methods linking, to be compatible with RxJS v8 #288

Closed e-oz closed 5 months ago

e-oz commented 6 months ago

This change removes a bit dirty method of combining the functionality of Angular Signal and RxJS Observable. Previously, every field of Observable instance was copied to a Signal object. Now we return a Proxy object, that only returns a method of the Observable instance if the Signal instance does not have the requested method.

nx-cloud[bot] commented 6 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f9659c7003939e8af064a8b9f2401c74384aea2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/fPe4XqaS3Z?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --ci --code-coverage`](https://cloud.nx.app/runs/LyR6nLUULD?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=build --parallel=3 --exclude=docs`](https://cloud.nx.app/runs/ZKhhM2wyol?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

eneajaho commented 5 months ago

Hello @e-oz Can you rebase this ? And then I think we can merge 🙌

e-oz commented 5 months ago

Hi @eneajaho Done ✅