search

ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
576 stars 83 forks source link

injectQueryParams (key) has incorrect type #325

Closed james-schwartzkopf closed 3 months ago

james-schwartzkopf commented 5 months ago

injectQueryParams(key) says it returns Signal<string | null> but could also return an array of strings.

I would suggest changing the current version to return the first string in the array if it's an array. That would keep it compatible with what people are expecting, Maybe add an optional flag that would force it to an array if it's a single string. Similar to getAll on ParamMap.

Dafnik commented 5 months ago

This should be solved by #232

Dafnik commented 4 months ago

Can you confirm if it's fixed?

Dafnik commented 3 months ago

I think this can also be closed! @eneajaho