search

ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
576 stars 83 forks source link

feat: add provider function for configuring route injection functions #336

Closed eneajaho closed 4 months ago

eneajaho commented 4 months ago

PS: I'm not so sure about this!

One other way to fix this is to use snapshot and get rid of requireSync at all.

cc @nartc @fiorelozere @ajitzero

nx-cloud[bot] commented 4 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit abc5deff7c2cb3aa5d036e0a112c0f54567fe455. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets - [`nx affected --target=build --parallel=3 --exclude=docs`](https://cloud.nx.app/runs/SjRv8KrFJ9?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3`](https://cloud.nx.app/runs/kezWqhqzss?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/dr00CBPQZE?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- nx format:check`](https://cloud.nx.app/runs/vTsKYsjcLi?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

eneajaho commented 4 months ago

Going with a different approach:

https://github.com/nartc/ngxtension-platform/pull/339

This should not fail anymore, but Ionic users will have to check for the value if it's nullish before using them.