ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
544 stars 80 forks source link

Package "ngxtension" has a missing peer dependency of "@use-gesture/vanilla" @ "^10.0.0". #348

Closed kle-pra closed 3 months ago

kle-pra commented 3 months ago

I noticed this warning when running update script and am opening just in case it needs some attention.

We are not using gestures so it doesn't seem to affect us but would you still recommend installing this as a dependency when using ngxtension version. 3.x?

eneajaho commented 3 months ago

Hello @kle-pra . That's an optional dependency. You don't need to install it.

@nartc Should we add optional to it?

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

"peerDependenciesMeta": {
    "@use-gesture/vanilla": {
      "optional": true
    }
  }
sysmat commented 3 months ago

I think if project dos not use gesture it is misleading, I'm in favor of optional

kle-pra commented 3 months ago

Thanks @eneajaho for explanation and suggestion, I also support optional.