Closed joshuamorony closed 2 months ago
Sounds like a fair tradeoff to me. If the pattern of this PR and the base PR is to de-couple signalSlice
from formal effect blocks, then having some sort distinction between other effect
in a file unrelated to the slice and effect
related to the slice is a nice tradeoff.
Hello @joshuamorony Can you add the breaking change in the commit description if this is a breaking change?
@eneajaho we ended up merging #361 and this is ready for review now (no breaking changes in this PR)
@joshuamorony can you rebase? Then I can merge
@eneajaho done
NOTE: This depends on https://github.com/ngxtension/ngxtension-platform/pull/361 being merged, this is branched off of that feature
This is a replacement for the removal of the
actionEffect
API, instead it allows triggering side effects as a result of anactionSource
emitting via a notifier/version signal (same general concept we used forcreateNotifier
).It adds a
<actionSourceName>Updated
signal for each action source e.g:This is a much simpler API and avoids the typing issues (described in: https://github.com/ngxtension/ngxtension-platform/pull/361)