search

ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
531 stars 77 forks source link

(bug) Press Kit images not found #411

Closed jdegand closed 1 week ago

jdegand commented 1 month ago

407 recently updated the file paths. .png was used on lines 9 & 10 (all the logos are .svg). This may contribute to the problem.

michael-small commented 1 month ago

Good catch with the .png in that PR. I copied it over from the other index.mdx blindly. However, it seems that flipping between dark theme and light theme doesn't change it to ngxt-white for the dark theme from what I can tell building it locally with the the .svg paths.

That .png copy over isn't related to why the press kit though. I'm not sure why the press kit images are still not loading, as it worked locally after I changed it and lodged PR 407.

jdegand commented 1 month ago

If it is related to themes, I ran into similar problems before with astro. The Auto setting causes problems with conditionals.

jdegand commented 2 weeks ago

I don't think dark mode has anything to do with this.

Got Files in the public directory are served at the root path warning when I ran the docs with pnpm run dev inside /docs folder. But if you remove public from image urls in index.mdx, the docs fail to compile. I think you can delete public from the images' paths inside logos.md and maybe that might work.