search

ngxtension / ngxtension-platform

Utilities for Angular
https://ngxtension.netlify.app/
MIT License
591 stars 87 forks source link

`whenDocumentVisible` is not exported from `ngxtension/when-document-visible` entry point #424

Closed FabienDehopre closed 3 months ago

FabienDehopre commented 3 months ago

I forgot to export the whenDocumentVisible operator from the entry point. :( I'll provide a PR as soon as possible.

FabienDehopre commented 3 months ago

@nartc or @eneajaho Sorry to bother you but this bug is important because the RxJS whenDocumentVisible operator is not exported from the entrypoint ngxtension/when-document-visible which makes it impossible to use. I know it's my fault because I forgot to check the index.ts file before subimiting the initial implementation. However, the PR that fixes the bug is ready since last week. I would really appreciate if one of you (or any other code owner) can review the PR. Thanks in advance.

eneajaho commented 3 months ago

Merged your fix. Thanks 🙏

sysmat commented 3 months ago

"ngxtension": "3.5.5", still not exported

FabienDehopre commented 3 months ago

@sysmat I believe that the fix has not been released yet. Version 3.5.5 has been released before the merge of the fix.

sysmat commented 3 months ago

any progress?

FabienDehopre commented 2 months ago

@nartc any idea when you can release this fix?

sysmat commented 2 months ago

any progress

eneajaho commented 2 months ago

Sorry for delay. Released here https://github.com/ngxtension/ngxtension-platform/releases/tag/4.0.0